feat: postgrest 13 add maxaffected in client libraries #619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tgrest-v13-integration' into avallete/psql-372-postgrest-add-maxaffected-in-client-libraries
soedirgo
reviewed
May 20, 2025
soedirgo
reviewed
May 20, 2025
…tgrest-v13-integration' into avallete/psql-372-postgrest-add-maxaffected-in-client-libraries
Comment on lines
+343
to
+352
| /** | ||
| * Set the maximum number of rows that can be affected by the query. | ||
| * Only available in PostgREST v13+ and only works with PATCH and DELETE methods. | ||
| * | ||
| * @param value - The maximum number of rows that can be affected | ||
| */ | ||
| maxAffected( | ||
| value: number | ||
| ): ClientOptions['postgrestVersion'] extends 13 | ||
| ? Method extends 'PATCH' | 'DELETE' |
There was a problem hiding this comment.
A nice-to-have on typescript would be a validation that the function returns SETOF, otherwise the failure would be at runtime I believe.
There was a problem hiding this comment.
Good catch didn't tested the rpc they do have their own kind of typing though because they're a bit specifics.
About the "set of" that's actually something I wanna work on. It will be related to "embedded relationships with functions". I have some draft I need to find the time to work on it.
For now I think runtime error is okay, but we'll surely be able to catch that at type level at some point indeed. Just wondering, what if the function doesn't returns a setof but just plain records ? Or return table ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
HeadersAPIHeaders)